Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer seems to not update tilesheet images when re-importing. #35

Closed
radicaled opened this issue Jul 15, 2017 · 8 comments
Closed

Importer seems to not update tilesheet images when re-importing. #35

radicaled opened this issue Jul 15, 2017 · 8 comments

Comments

@radicaled
Copy link
Contributor

I made some pretty big edits to my tilesheet in order to use Tiled's awesome Terrain Tool. Mainly lots of moving tiles around in the .png.

However, it seems like the importer didn't re-import my tilesheet image -- so the map came out looking insane. I opened up the generated .scn file in Godot, and glanced through its Tilemaps, and it was obvious it was using an old (cached?) version of the the tilesheet.

Importing the .tmx file and saving it into a new scene works perfectly fine, though.

@radicaled
Copy link
Contributor Author

I restarted Godot and the map suddenly started rendering fine!

Is this a bug in Godot? Or maybe the plugin isn't signaling to Godot that internal assets have been updated, so its not re-rendering the tilesets?

@vnen
Copy link
Owner

vnen commented Jul 15, 2017

This is more related to how Godot handle resources than to this plugin. Are you embedding the images in the TileSet when importing?

TBH I think what's happening is that the editor is already using the resource and thus don't update to the newer version. So if you restart the editor (maybe only the scene) it'll work. I'll try to make some tests later.

@radicaled
Copy link
Contributor Author

Are you embedding the images in the TileSet when importing?

Yep. I'm storing my .tmx and .tsx and other assets in the project, so I don't want duplicate files I might accidentally edit hanging around, so I import everything as a single .scn file.

TBH I think what's happening is that the editor is already using the resource and thus don't update to the newer version. So if you restart the editor (maybe only the scene) it'll work.

I believe I opened and closed the affected scene and nothing changed

@radicaled
Copy link
Contributor Author

I can now reproduce this issue consistently. If my only changes to a Tiled map are adding "tile" objects to an object layer, Godot won't update the imported scene unless I open / close it or restart Godot.

Is this a known issue in Godot? Any issue # I can track against?

@vnen
Copy link
Owner

vnen commented Aug 13, 2017

Godot won't update the open scene, you really need to close and reopen it. This will be fixed in Godot 3.0, as there'll be a way to reload the scene from the plugin.

@vnen
Copy link
Owner

vnen commented Jan 25, 2018

This is solved on Godot 3, and there's nothing this plugin can do anyway, so I'll close this.

@vnen vnen closed this as completed Jan 25, 2018
@gusg21
Copy link

gusg21 commented Jul 13, 2020

Hi, sorry to reopen an old issue, but this appears to be still happening. Godot 3.2, Windows 10. Both the tileset and the tilemap don't update in other scenes unless I open the map scene.

@vnen
Copy link
Owner

vnen commented Aug 8, 2020

As said, this is more of an issue with Godot, there's nothing that can be done from the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants