Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling fallback to html document title #1

Open
CedricReichenbach opened this issue Mar 6, 2017 · 0 comments
Open

Support disabling fallback to html document title #1

CedricReichenbach opened this issue Mar 6, 2017 · 0 comments

Comments

@CedricReichenbach
Copy link

If a website doesn't support oEmbed, this library falls back to document title and some meta tags (e.g. for description) instead of just leaving them null. This is problematic when other meta data sources (like OpenGraph) besides oEmbed, since getTitle() will always return a non-null value.

My current workaround is to check getVersion() as indicator whether data was fetched from an actual oEmbed endpoint, but that's quite hacky. It would be nice to have an option to disable default behavrior, e.g. through an argument like boolean useMetaTagFallbacks in the constructor of DefaultOEmbedProvider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant