New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configerable average function #23
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #23 +/- ##
===========================================
+ Coverage 95.95% 96.03% +0.07%
===========================================
Files 18 18
Lines 1137 1159 +22
===========================================
+ Hits 1091 1113 +22
Misses 46 46
Continue to review full report at Codecov.
|
I think so, although the documentation for the public function is missing (and in a future PR I should merge the public and
You mean the statistic with the mean, median or both? |
I mean with the median. Using the mean is one of your tests, which passes. |
Ok, I have checked the implementation and it looks ok. The only explanation that I see is that the differences between the Gaussian and t-Student distributions are in the tails of the distribution, and the median is not taking this information into account. Maybe it will notice the difference with a higher number of samples, but it would be very costly. So I would add a test between two different enough distributions with the same mean, and call it a day, unless you have a better explanation. |
Closes #22, see discussion there.
Uncertainties:
test_different_distributions
. Does this make sense, or is it revealing a flaw in the code somewhere?