Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diaspora share + between words instead of spaces. #58

Closed
paskalito opened this issue Jan 20, 2016 · 4 comments
Closed

Diaspora share + between words instead of spaces. #58

paskalito opened this issue Jan 20, 2016 · 4 comments

Comments

@paskalito
Copy link
Contributor

Hi

I made a post on this alrady on t a closed issue which i think noone gets notifications from anymore and i couldnt find a way to contact @manno so i made a new issue for that.

here is the problem:
#7 (comment)

@manno
Copy link
Member

manno commented Jan 20, 2016

I think the Ruby method works as expected.

However the Javascript encodeURIComponent does not change white space into plus signs.

I could replace all + with %20 though, would that help?

@paskalito
Copy link
Contributor Author

YESS!, i think so because i got the expected result when i manually opened this url.

https://nerdpol.ch/bookmarklet?url=https%3A%2F%2Fshare.diasporafoundation.org%2Fabout.html&title=Share%20to%20diaspora*%20with%20as%20many%20spaces%20as%20possible

on "my" pod (nerdpol.ch)

very good idea.

@paskalito
Copy link
Contributor Author

seems like you've fixed it right?
at least the issue seems to be gone for me :D
thank you

@paskalito
Copy link
Contributor Author

ok i just found out i have rights to close this issue i will do it then.

and a little picture for documentaiton purposes.

bildschirmfoto vom 2016-02-03 14-48-19

honors go to @manno for this commit 134c33c :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants