Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running pontis #2

Closed
henrikra opened this issue Jul 25, 2022 · 2 comments
Closed

Error when running pontis #2

henrikra opened this issue Jul 25, 2022 · 2 comments
Labels

Comments

@henrikra
Copy link

Hey and thanks for the nice idea for a simple Chrome extension authentication!

After I have installed this package and when I run it I get error Module not found: Error: Can't resolve '@aws-amplify/core' since I am using amazon-cognito-identity-js as auth package. Maybe you should move @aws-amplify/core from devDependencies to dependencies to fix this issue?

@henrikra henrikra mentioned this issue Jul 28, 2022
@sneas sneas closed this as completed in cef51dc Jul 30, 2022
@sneas
Copy link
Contributor

sneas commented Jul 30, 2022

Thank you for the suggestion, @henrikra 👍 In the end, I decided to add @amplify/core as a peer dependency and update pontis installation instructions instead of adding it to dependencies. The reason for not having @amplify/core in the project's dependencies is @amplify/core is too big and way better maintained. Having it in dependencies will inevitably make me responsible for syncing with new major versions of @amplify/core.

@sneas
Copy link
Contributor

sneas commented Dec 23, 2022

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sneas sneas added the released label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants