Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix train so it works with validation set #57

Closed
NickleDave opened this issue Jun 23, 2019 · 2 comments
Closed

fix train so it works with validation set #57

NickleDave opened this issue Jun 23, 2019 · 2 comments
Projects
BUG/MAINT
Milestone
0.4.0

Comments

@NickleDave
Copy link
Collaborator

No description provided.

@NickleDave NickleDave added this to To Do in BUG/MAINT Jun 23, 2019
@NickleDave NickleDave moved this from To Do to In Progress in BUG/MAINT Jun 23, 2019
@NickleDave
Copy link
Collaborator Author

NickleDave commented Jun 23, 2019 •
edited

Was getting an error because dataset.split and the functions it uses, e.g. splitalgos.bruteforce assume there will always be a test set.

Fix this in a somewhat hacky way by re-writing all the functions to accept test_dur of 0.
See:
8de4cf5
df7116e
f1ae0dd

But now this muddles up train_test_dur_split function and a more general split function that isn't trying to have a sklearn-like API

@NickleDave NickleDave mentioned this issue Jun 23, 2019
Closed
@NickleDave NickleDave added this to the 0.2.0 milestone Jun 26, 2019
@NickleDave
Copy link
Collaborator Author

We currently have this functionality so I am closing this issue

@NickleDave NickleDave moved this from In Progress to Done in BUG/MAINT Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
BUG/MAINT
Done
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@NickleDave