Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add TrainerConfig to train/learncurve/eval/predict #691

Closed
3 tasks
Tracked by #614
NickleDave opened this issue Aug 14, 2023 · 1 comment
Closed
3 tasks
Tracked by #614

ENH: Add TrainerConfig to train/learncurve/eval/predict #691

NickleDave opened this issue Aug 14, 2023 · 1 comment
Assignees

Comments

@NickleDave
Copy link
Collaborator

This is part of the fix for #687. I think we should just be explicit we're using Lightning

  • Change 'device' option to 'accelarator' in config files
  • Rename 'get_default_device' -> 'get_default_accelerator'
  • Define 'accelerator' in docs, link to Lightning docs
@NickleDave NickleDave self-assigned this Aug 14, 2023
@NickleDave NickleDave changed the title ENH: Refer to 'accelerator' not 'device' ENH: Add TrainerConfig to train/learncurve/eval/predict May 1, 2024
@NickleDave
Copy link
Collaborator Author

NickleDave commented May 1, 2024

Renaming this to reflect that we want a table representing lightning.Trainer arguments in the config.

This will help address #742 and #745 as well.

We define a sub-table trainer for the train/learncurve/eval/predict configs

accelerator = 'cpu'

It should default to accelerator=get_default() and devices=1 to fix the above issues, and for now we will need to raise informative errors if someone tries to run on multiple devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant