Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager should accept identifiers in urls with and without 0x prefix #27

Open
elboletaire opened this issue Mar 5, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@elboletaire
Copy link
Member

Bug description

Backend will start generating all urls without 0x, but we still need to give backwards compatibility, allowing urls with and without the 0x

Steps to reproduce

  • Create a process in the manager (stage), setting the web poll to on, with a valid census and at least one valid user to receive the e-mail
  • As soon as you receive the e-mail for the webpoll, you'll see it's format is like https://manager.stg.vocdoni.net/processes/vote/#/0x{id}/{id}/0x{id}
  • It won't load due to the identifier in the middle not having the prefixed 0x

Current behavior

It fails loading processes where one or many 0x where missing.

Expected behavior

Should load with and without 0x in any of the three identifiers provided in the url.

System:

  • Browser: irrelevant
  • Commit hash: latest
@elboletaire elboletaire added the bug Something isn't working label Mar 5, 2021
@elboletaire
Copy link
Member Author

elboletaire commented Mar 5, 2021

This is actually in issue with dvote-js and dvote-solidity not accepting (yet) non hex prefixed strings. I'll create issues there to properly track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant