Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - revert: support streaming with knowledge base (PL-1097) #824

Closed
wants to merge 1 commit into from

Conversation

theProf
Copy link
Contributor

@theProf theProf commented May 23, 2024

Brief description. What is this change?

Wrong commit was reverted (GPT-o) previously

@theProf theProf requested a review from trs May 23, 2024 12:38
Copy link

linear bot commented May 23, 2024

Copy link

graphite-app bot commented May 23, 2024

Warning

Your PR exceeds 500 lines changed! 🐘
it will be labelled as (large size) 😢

If this is more than 500 lines of code that you expect the reviewer to read, please consider breaking down your PR into smaller components 🙏📦📦📦. Otherwise, delete this comment + label if all changes are intended.

This is best practice as it helps us review code faster, and effectively catch bugs. Be mindful for your reviewer. Consult a senior engineer, or team lead for assistance on PR strategy. Tools such as graphite/stacking PRs may also be helpful 📦

@theProf theProf changed the title Revert "feat: support streaming with knowledge base" (PL-987) revert support streaming with knowledge base (PL-987) May 23, 2024
@theProf theProf changed the title revert support streaming with knowledge base (PL-987) revert: support streaming with knowledge base (PL-987) May 23, 2024
@theProf
Copy link
Contributor Author

theProf commented May 23, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request May 23, 2024
### Brief description. What is this change?
Wrong commit was reverted (GPT-o) previously

Co-authored-by: Greg O'Grady <gregory.ogrady@voiceflow.com>
Copy link

sonarcloud bot commented May 23, 2024

@bors-vf
Copy link

bors-vf bot commented May 23, 2024

Build failed:

@theProf
Copy link
Contributor Author

theProf commented May 23, 2024

Bors r+

bors-vf bot pushed a commit that referenced this pull request May 23, 2024
### Brief description. What is this change?
Wrong commit was reverted (GPT-o) previously

Co-authored-by: Greg O'Grady <gregory.ogrady@voiceflow.com>
@bors-vf
Copy link

bors-vf bot commented May 23, 2024

Build failed:

@pmvrmc
Copy link
Contributor

pmvrmc commented May 23, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request May 23, 2024
### Brief description. What is this change?
Wrong commit was reverted (GPT-o) previously

Co-authored-by: Greg O'Grady <gregory.ogrady@voiceflow.com>
@bors-vf
Copy link

bors-vf bot commented May 23, 2024

Build failed:

@theProf theProf changed the title revert: support streaming with knowledge base (PL-987) revert: support streaming with knowledge base (PL-1097) May 23, 2024
Copy link

linear bot commented May 23, 2024

@pmvrmc
Copy link
Contributor

pmvrmc commented May 23, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request May 23, 2024
### Brief description. What is this change?
Wrong commit was reverted (GPT-o) previously

Co-authored-by: Greg O'Grady <gregory.ogrady@voiceflow.com>
@bors-vf
Copy link

bors-vf bot commented May 23, 2024

Build failed:

@pmvrmc
Copy link
Contributor

pmvrmc commented May 23, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request May 23, 2024
### Brief description. What is this change?
Wrong commit was reverted (GPT-o) previously

Co-authored-by: Greg O'Grady <gregory.ogrady@voiceflow.com>
@bors-vf
Copy link

bors-vf bot commented May 23, 2024

@bors-vf bors-vf bot changed the title revert: support streaming with knowledge base (PL-1097) [Merged by Bors] - revert: support streaming with knowledge base (PL-1097) May 23, 2024
@bors-vf bors-vf bot closed this May 23, 2024
@bors-vf bors-vf bot deleted the greg/revert-kb-streaming/PL-000 branch May 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants