Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia340: broken with linux5.4 #16923

Closed
Hoshpak opened this issue Nov 29, 2019 · 2 comments · Fixed by #17999
Closed

nvidia340: broken with linux5.4 #16923

Hoshpak opened this issue Nov 29, 2019 · 2 comments · Fixed by #17999
Labels
bug Something isn't working

Comments

@Hoshpak
Copy link
Member

Hoshpak commented Nov 29, 2019

nvidia340 fails to compile the kernel module via dkms and complains about missing Makefiles. I suspect that the use of SUBDIRS is the culprit since the 5.3 Makefile already warns against using that when compiling the module:

Makefile:213: ================= WARNING ================
Makefile:214: 'SUBDIRS' will be removed after Linux 5.3
Makefile:215: 
Makefile:216: If you are building an individual subdirectory
Makefile:217: in the kernel tree, you can do like this:
Makefile:218: $ make path/to/dir/you/want/to/build/
Makefile:219: (Do not forget the trailing slash)
Makefile:220: 
Makefile:221: If you are building an external module,
Makefile:222: Please use 'M=' or 'KBUILD_EXTMOD' instead
Makefile:223: ==========================================

The package needs to be patched or updated if nvidia releases a compatible version.

@Hoshpak Hoshpak added the bug Something isn't working label Nov 29, 2019
@st3r4g
Copy link
Contributor

st3r4g commented Dec 31, 2019

@newbluemoon
Copy link
Contributor

Just to add: Tested #17999 with kernels 5.4, 5.3, and 4.19 on i686, everything works so far. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants