Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obs studio (GPL2+) includes MIT licensed plugin in package #19434

Closed
obunden opened this issue Feb 23, 2020 · 6 comments
Closed

Obs studio (GPL2+) includes MIT licensed plugin in package #19434

obunden opened this issue Feb 23, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@obunden
Copy link
Contributor

obunden commented Feb 23, 2020

If i'm not mistaken 'ftl-sdk' is MIT licensed and Obs is GPL2 (or later). It's probably best to put it in a separate package to avoid issues or confusion. Might also be worth it to do the same with the rest of the plugins for simplicity/maintenance reasons.

@obunden
Copy link
Contributor Author

obunden commented Feb 23, 2020

Just noticed that I can't see the browser plugin inside of obs so there might be other issues with the package. @lemmi if you are using obs could you check if this is accurate?

@lemmi
Copy link
Member

lemmi commented Feb 23, 2020

I didn't add those plugins and I'm not using them. I think @the-eater added those. Maybe he can jump in. If not, I'll look into it.

@the-eater
Copy link
Contributor

I just added all the then git submodules that existed, the browser doesn't build because we don't have CEF. (might be a nice to have 🤔)

outside that, ftl-sdk is compiled statically into obs-outputs.so plugin, which makes the licenses problem also exist upstream? we can bundle it on it's own, but it's a requirement of running obs so idk what the best action is to take here

@lemmi
Copy link
Member

lemmi commented Mar 20, 2020

so .. finally got the time to look at this. I don't like it one bit and I'm very close to just removing ftl from obs unless someone else is willing to make a package for it.
The obs-vst plugin doesn't have a release. So it's either out aswell or left as submodule. Plus there is plenty filters to be had via jack/ladspa...
obs-browser needs CEF and I will not be maintaining that.

Unless I'm missing something, I'm going to the remove the extra bits soon.

@lemmi
Copy link
Member

lemmi commented Mar 29, 2020

Closed in 7e42a51

@lemmi lemmi closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@the-eater @lemmi @obunden and others