Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly set conf_files #21649

Open
Gottox opened this issue May 5, 2020 · 13 comments
Open

Implicitly set conf_files #21649

Gottox opened this issue May 5, 2020 · 13 comments
Assignees

Comments

@Gottox
Copy link
Member

Gottox commented May 5, 2020

What about marking any files in /etc automaticly as conf_files. are there any counter-examples where this would break anything?

@Duncaen
Copy link
Member

Duncaen commented May 5, 2020

Yes scripts in /etc/sv/ and /etc/runit should probably not be conf_files by default, especially if a user sets keepconf=yes in xbps.d, which will always create .new-$version files even if the previous configuration file was never changed.

@sgn
Copy link
Member

sgn commented May 5, 2020

  • Files provided by grml-zsh-config
  • /etc/bash/bashrc (not sure about this one)

Those files shouldn't be marked as conf

@Chocimier
Copy link
Member

Good idea.

Skimmed through xlocate, nothing besides what Duncaen pointed seems to need to be excluded.

@Gottox
Copy link
Member Author

Gottox commented May 18, 2020

basicly Debian for example does.

@Gottox
Copy link
Member Author

Gottox commented May 18, 2020

I'll make a PR that addresses this issue and respects @Duncaen's comments.

@travankor
Copy link
Contributor

travankor commented May 18, 2020

Should /etc/sv/service/confcount as conf?

@ericonr
Copy link
Member

ericonr commented Jul 11, 2020

AppArmor profiles aren't conf files either. They are in /etc/apparmor.d/, but the local files in /etc/apparmor.d/local/ are conf files.

@Duncaen what do you think about making /etc/runit/ctrlaltdel a conf_file? It is something that a user can change depending on the action they want to trigger when they use that keyboard shortcut.

Should /etc/sv/service/confcount as conf?

@travankor IMO yes, it's where we recommend users make changes that persist across package updates. I believe the vsv function marks those as conf by default.

How would this work for new applications that for some reason store files in /etc that aren't config files? Will we have a new no_conf_files or no_auto_conf_file field, or have to add exceptions to the script?


To keep track, stuff I can think of in /etc/ that aren't conf:

  • kernel.d/
  • os-release ?
  • some/most(?) of the stuff in zfs/
  • polkit-1/rules.d/50-default.rules

@ericonr
Copy link
Member

ericonr commented Jan 21, 2021

Ping?

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 16, 2022
@paper42 paper42 removed the Stale label Apr 16, 2022
@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2023
@Chocimier Chocimier reopened this Jan 30, 2023
@Chocimier
Copy link
Member

Blocked on void-linux/xbps#342

@github-actions github-actions bot removed the Stale label Jan 31, 2023
@Chocimier Chocimier self-assigned this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants