Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-magic and pass-import problem #23535

Closed
bda65 opened this issue Jul 12, 2020 · 5 comments
Closed

python3-magic and pass-import problem #23535

bda65 opened this issue Jul 12, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@bda65
Copy link

bda65 commented Jul 12, 2020

System

x86_64 Glibc

  • xuname:
    *Void 5.7.8_1 x86_64 GenuineIntel uptodate rrFFFF
  • packages:
    *python3-magic-0.4.18_1
    *pass-import-3.0_1

Actual behavior

Import from cvs file (exported from firefox) return this:

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/lib/python3.8/site-packages/pass_import/__main__.py", line 425, in <module>
    main()
  File "/usr/lib/python3.8/site-packages/pass_import/__main__.py", line 407, in main
    decryptsource(conf)
  File "/usr/lib/python3.8/site-packages/pass_import/__main__.py", line 260, in decryptsource
    frmt, encoding = get_magics(path)
  File "/usr/lib/python3.8/site-packages/pass_import/tools.py", line 42, in get_magics
    res = magic.detect_from_content(header)
AttributeError: module 'magic' has no attribute 'detect_from_content'

Steps to reproduce the behavior

pass import csv file.csv --cols 'url,login,pass'
@bda65
Copy link
Author

bda65 commented Jul 12, 2020

It seem to be corrected here roddhjav/pass-import#103

@sgn
Copy link
Member

sgn commented Jul 13, 2020

Yes, pass-import needs file-magic instead of magic

@sgn sgn added the bug Something isn't working label Jul 13, 2020
@sgn sgn self-assigned this Jul 13, 2020
@sgn
Copy link
Member

sgn commented Jul 13, 2020

There's a serious test failure when packaging this. I'll look into it later.

@bda65
Copy link
Author

bda65 commented Jul 13, 2020

Thanks :)
I've patched manually with any test. It work well with firefox import.

@sgn
Copy link
Member

sgn commented Jul 13, 2020 via email

@sgn sgn closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants