Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set wrksrc with whitespace? #24477

Closed
muni-corn opened this issue Aug 26, 2020 · 6 comments · Fixed by #24613
Closed

How to set wrksrc with whitespace? #24477

muni-corn opened this issue Aug 26, 2020 · 6 comments · Fixed by #24613

Comments

@muni-corn
Copy link
Contributor

muni-corn commented Aug 26, 2020

I've got a template in progress for this one, but with one major issue. I'm having a hard time copying the font files because the archive/distfiles have directories with spaces in them and I haven't found out yet how to circumvent this.

This is the directory structure of the zip file (from this release):

Directory structure of Inter zip file

We're supposed to copy the files from "Inter Desktop" into our font directories. I've tried a number of things to try and solve the whitespace-in-wrksrc problem, but no luck yet. What's the right way to go about this?

# Template file for 'font-inter'
pkgname=font-inter
version=3.15
revision=1
archs="noarch"
hostmakedepends=""
makedepends=""
depends="font-util"
short_desc="Typeface specially designed for user interfaces"
maintainer="Harrison Thorne <harrisonthorne@protonmail.com>"
license="OFL-1.1"
homepage="https://rsms.me/inter/"
distfiles="https://github.com/rsms/inter/releases/download/v${version}/Inter-${version}.zip"
checksum=1534288eb599f57acbf2c5ac0010da9495c2ee53116e08d799555c6f8ee22156
wrksrc="Inter Desktop"

font_dirs="/usr/share/fonts/Inter/"

do_install() {
    ls
    vmkdir usr/share/fonts/Inter
    vcopy * usr/share/fonts/Inter
    vlicense LICENSE # ??? added in with edit below
}

Edit: About the LICENSE file too, will wrksrc then have to be .? I'm confused about how all of this will work :P

@flexibeast
Copy link
Contributor

Does this font provide glyphs that aren't otherwise provided by fonts in the repos? If not, this package is unlikely to be accepted, due to our quality requirements.

@muni-corn
Copy link
Contributor Author

Fair enough, but how would I go about this anyways if I wanted to make my own local template?

@muni-corn muni-corn changed the title Package request: font-inter How to set wrksrc with whitespace? Aug 27, 2020
@Anachron
Copy link
Contributor

What's the issue when you try to build the package? If your template doesn't work then something in xbps-src is broken when quoting wrksrc.

@ericonr
Copy link
Member

ericonr commented Aug 27, 2020

xbps-src really doesn't do a lot of quoting. Best course of action might be to mv "folder with spaces" folder-without-spaces in post_extract

@Anachron
Copy link
Contributor

Anachron commented Aug 27, 2020

@ericonr found at least these places where quoting is wrong:


mkdir -p ${wrksrc} || msg_error "$pkgver: failed to create wrksrc.\n"

Edit: Here too

cd $build_wrksrc || \

The quoting in xbps-src is very randomly.

@Chocimier
Copy link
Member

Works now with updated xbps-src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants