Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proftpd in void linux #25914

Closed
herveq1 opened this issue Oct 27, 2020 · 4 comments
Closed

proftpd in void linux #25914

herveq1 opened this issue Oct 27, 2020 · 4 comments
Labels

Comments

@herveq1
Copy link

herveq1 commented Oct 27, 2020

System

  • xuname:
    output of xuname (part of xtools)
  • package:
    affected package(s) including the version: xbps-query -p pkgver <pkgname>
    xuname
    Void 5.8.16_1 x86_64-musl GenuineIntel notuptodate rFF
    xbps-query -p pkgver proftpd
    proftpd-1.3.7a_1

Expected behavior

at least let the user to login

Actual behaviorfailed

login

Steps to reproduce the behavior

Hello dear maintainer of proftpd

There is now a few number of years that you are delevering a proftpd server
for which nobody can login in. That is useless...unless you are working with
windows in mind.

The result of your distribution proftpd-1.3.7a_1 is:

Password:
530 Login incorrect.
ftp: Login failed.
Remote system type is UNIX.
Using binary mode to transfer files.

When I take the proftpd distribution package proftpd-1.3.7a and compile it
with this command :
./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var/lib/proftpd --enable-auth-pam

With the same configuration file, I get this result that is quite OK.
Name (olix:hq): 331 Password required for hq
Password:
230 User hq logged in
Remote system type is UNIX.
Using binary mode to transfer files

Did you spend 1 minute to test your binary ?

Have fun

@Duncaen
Copy link
Member

Duncaen commented Oct 27, 2020

Did you spend 1 minute to test your binary ?

Have you considered that it might be intentional and unless someone asks for it the maintainer who probably doesn't even use ftp anymore doesn't know that someone might want to use system users for authentication?

@fosslinux
Copy link
Contributor

What @Duncaen said, and, how do you know that it hasn't broken in the meantime by an unrelated change to the Void ecosystem and it did work at the time of commit? The maintainers here are very busy and can't constantly be checking random small packages to check that they work just because they haven't been changed for a few months.

Furthermore, I don't think very many people at all use authenticated FTP... it's probably not something in a testing regime.

Surely, you have the 5 minutes available to make a pull request adding --enable-auth-pam to the configure_args?

@Piraty
Copy link
Member

Piraty commented Oct 31, 2020

as a build option, ideally

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants