Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlogout doesn't work with runit right now #26146

Closed
rupansh opened this issue Nov 5, 2020 · 8 comments
Closed

wlogout doesn't work with runit right now #26146

rupansh opened this issue Nov 5, 2020 · 8 comments
Labels

Comments

@rupansh
Copy link

rupansh commented Nov 5, 2020

System

  • xuname:
    Void 5.8.18_1 x86_64 GenuineIntel uptodate rFFFF
  • package:
    affected package(s) including the version: wlogout-1.1.1_1

Expected behavior

Shutdown and reboot should work

Actual behavior

Shutdown and reboot expects systemctl
sh: 1: systemctl: not found
and thus doesnt work

Steps to reproduce the behavior

wlogout
click reboot/shutdown/hibernate

@rupansh
Copy link
Author

rupansh commented Nov 5, 2020

Possible fix: Ship with our own default config that uses runit instead

@ericonr
Copy link
Member

ericonr commented Nov 5, 2020

Not exactly ideal, because the runit solutions would require sudo or doas (or even pkexec) to gain privileges, and that's very varied. I would suggest switching to depending on elogind and using loginctl <action>.

@rupansh
Copy link
Author

rupansh commented Nov 5, 2020

Not exactly ideal, because the runit solutions would require sudo or doas (or even pkexec) to gain privileges, and that's very varied. I would suggest switching to depending on elogind and using loginctl <action>.

Well a unified solution for all users would be nice. Ideally we should avoid adding dependencies that arent used by all wayland users

@ericonr
Copy link
Member

ericonr commented Nov 5, 2020

That's true.

@travankor thoughts?

@travankor
Copy link
Contributor

How does this sound?

  1. Switch the files in /etc/ to loginctl <action>
  2. Don't add elogind as a dependency since xbps does not handle optional dependencies

Expected behavior
Shutdown and reboot should work

By the way, you can add custom commands to your dotfiles ~/.config/wlogout as per the manpage.

@rupansh
Copy link
Author

rupansh commented Nov 6, 2020

How does this sound?

1. Switch the files in `/etc/` to `loginctl <action>`

2. Don't add elogind as a dependency since xbps does not handle optional dependencies

Not really ideal but yeah i couldnt come up with anything else. It should print a warning about it too

Expected behavior
Shutdown and reboot should work

By the way, you can add custom commands to your dotfiles ~/.config/wlogout as per the manpage.

Thanks

@ericonr
Copy link
Member

ericonr commented Jan 20, 2021

@travankor ping? I like your suggestion.

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants