Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: constrain PR's to cancel old duplicate actions #27972

Closed
waynevanson opened this issue Jan 17, 2021 · 4 comments
Closed

github-actions: constrain PR's to cancel old duplicate actions #27972

waynevanson opened this issue Jan 17, 2021 · 4 comments
Labels
help wanted Extra attention is needed Stale

Comments

@waynevanson
Copy link
Contributor

Here's a non-hypothetical example.

  • I created a PR for a new package, github actions trigger.
  • I made a small change in the dependencies and force pushed to the origin, github actions trigger again.

There are now 2 actions running, using resources. I went to go cancel the first one, but was unable to due to permissions.

An ideal solution is that when a force push is applied, it creates a new github action and the old one is deleted.
I'm unsure if this is even possible.

@ericonr
Copy link
Member

ericonr commented Jan 19, 2021

Doesn't it automatically kill the previous action? I remember observing such a behavior.

@waynevanson
Copy link
Contributor Author

I don't think so. Here are the actions: https://github.com/void-linux/void-packages/actions?query=branch%3Apackage%2Fwally-cli

Doesn't it automatically kill the previous action?

Perhaps force pushes skip this behavior. They use the commit as an identifier, so maybe because it can't tell what the previous commit was it does not know what it can and cannot cancel.

This is more of a quality of life change for the inexperience contributors or for when accidents happen.

@ericonr
Copy link
Member

ericonr commented Feb 4, 2021

@github-actions
Copy link

github-actions bot commented May 2, 2022

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants