Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Enabling appmenu (Global Menu) in Firefox 89 #31466

Closed
MPC7500 opened this issue Jun 13, 2021 · 2 comments
Closed

[Feature request] Enabling appmenu (Global Menu) in Firefox 89 #31466

MPC7500 opened this issue Jun 13, 2021 · 2 comments

Comments

@MPC7500
Copy link

MPC7500 commented Jun 13, 2021

Is it possible to merge the patch-set of the AUR for Firefox to the Void repository?
https://aur.archlinux.org/packages/firefox-appmenu/

@Duncaen
Copy link
Member

Duncaen commented Jun 13, 2021

We usually don't patch in features unless its really necessary. This patches is 5k lines long and we are already heavily patching firefox to just get it running on all platforms, I don't think adding more and even bigger patches is a good idea.

@ericonr
Copy link
Member

ericonr commented Jun 13, 2021

Agreed. We have 691 lines of build fixes, 5k lines on top that will have to be rebased ever so often for something that mozilla upstream already removed for some reason doesn't sound good to me.

Closing for now.

@ericonr ericonr closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants