Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbps-src will accept packages from remote repos as fullfilling dependencies even when they aren't available in srcpkgs/ #31526

Open
ericonr opened this issue Jun 16, 2021 · 6 comments
Assignees
Labels
Stale xbps-src xbps-src related

Comments

@ericonr
Copy link
Member

ericonr commented Jun 16, 2021

Writing a template to depend on zstd-devel (removed in d481489) should fail because srcpkgs/zstd-devel/template doesn't exist. Instead, if it's still available in remote repositories because it hasn't been cleaned up, it will be enough to satisfy the dependency.

An example from adding zstd-devel to depends for kicad-library.

   [target] zstd-devel: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [runtime] kicad-footprints-5.1.10_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [runtime] kicad-packages3D-5.1.10_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [runtime] kicad-symbols-5.1.10_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [runtime] kicad-templates-5.1.10_1: found (https://alpha.de.repo.voidlinux.org/current/musl)

This can lead to issues such as 5898b6c (fixed in d0ae888), where a package can be made to depend on another one that's no longer available.

When fixing this, care should be taken to not break virtual packages or others depending on the provides= mechanism (though arguably packages which are providesd by something are valid only in depends).

@ericonr ericonr added the xbps-src xbps-src related label Jun 16, 2021
@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 22, 2022
@Chocimier Chocimier removed the Stale label May 23, 2022
@Chocimier
Copy link
Member

Related: #31347

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
@Chocimier Chocimier reopened this Jul 11, 2023
@Chocimier Chocimier self-assigned this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale xbps-src xbps-src related
Projects
None yet
Development

No branches or pull requests

3 participants