Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic dependency: perl-HTML-Parser <-> perl-HTTP-Message #32468

Closed
r-ricci opened this issue Aug 12, 2021 · 6 comments
Closed

Cyclic dependency: perl-HTML-Parser <-> perl-HTTP-Message #32468

r-ricci opened this issue Aug 12, 2021 · 6 comments

Comments

@r-ricci
Copy link
Contributor

r-ricci commented Aug 12, 2021

perl-HTTP-Message is a check dependency of perl-HTML-Parser,
perl-HTML-Parser is a runtime and build dependency of perl-HTTP-Message.

When updating both packages (https://github.com/4ricci/void-packages/pull/31), ./xbps-src -Q pkg perl-HTTP-Message returns the error:

=> ERROR: Build-time cyclic dependency perl-HTML-Parser(host), perl-HTTP-Message(host), perl-HTML-Parser(host) detected.

./xbps-src -Q pkg perl-HTML-Parser returns the error:

=> ERROR: Build-time cyclic dependency perl-HTTP-Message(host), perl-HTML-Parser(host), perl-HTTP-Message(host) detected.
@ericonr
Copy link
Member

ericonr commented Aug 12, 2021

I think the correct path forward would be disabling tests for perl-HTML-Parser (or see if they can run without perl-HTTP-Message. Otherwise this means bootstrap is broken when tests are enabled, and we want to make bootstrap with tests possible.

@Chocimier
Copy link
Member

On the contrary, I think cycles due to checkdepends are better than not testing package at all. In case like here, one can first build package(s) locally without tests, than rebuild with tests enabled.

@dkwo
Copy link
Contributor

dkwo commented Aug 14, 2021

I also had to deal with the same issue here #32229

@r-ricci r-ricci closed this as completed Sep 18, 2021
@q66
Copy link
Contributor

q66 commented Sep 18, 2021

i think not testing is better because if tests are not cyclic, they can be properly automated (we could even have the builders run them eventually) while if you allow cycles they can't (and tests on stuff like this are mostly meaningless either way, i see no reason to let a few rare cases break it)

@q66
Copy link
Contributor

q66 commented Sep 18, 2021

also i think checkdepends are in general a poor idea because it means that your build environment differs if you're running tests vs if you're not

while ideally the build environment should only ever be affected by build options

@dkwo
Copy link
Contributor

dkwo commented Sep 19, 2021

Then, shall we treat checkdepends just as (host)makedepends, regardless of whether we are permorming tests or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants