Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hplip: incompatibility with python3.10 #33700

Closed
alandiwix opened this issue Oct 22, 2021 · 9 comments
Closed

hplip: incompatibility with python3.10 #33700

alandiwix opened this issue Oct 22, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@alandiwix
Copy link

See https://bugs.launchpad.net/hplip/+bug/1933973
There are several issues in hplip codebase, the one I encounter personally is:

Scanning...
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/usr/share/hplip/scan/sane.py", line 548, in run
    st, t = self.dev.readScan(readbuffer)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
Reading data: [\       

The error

SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

is common among those. Some other distributions managed to solve that, Fedora's patch for example:
https://launchpadlibrarian.net/546031954/hplip-pyssizet_clean.patch
Is it possible to do the same in Void?

@ericonr
Copy link
Member

ericonr commented Oct 24, 2021

Sure! Would you like to make a PR yourself or should someone else look into fixing it?

@ericonr ericonr added the bug Something isn't working label Oct 24, 2021
@biopsin
Copy link
Contributor

biopsin commented Oct 24, 2021

bump hplip to 3.21.8,
@alandiwix I can run some test, use it at work but not noticed any issues while scanning.. will look into it

@biopsin
Copy link
Contributor

biopsin commented Oct 25, 2021

@alandiwix I use xsane to scan so I can't reproduce the issue.
What args are you passing with hp-scan command?
I noticed hp-scan complains of missing python-image-library (PIL), so the template needs reviewing.
And also latest version need ajust for ../prnt/hpcups/libImageProcessor*.so
Ok I'll look at again.

@misterupkeep
Copy link

@biopsin hp-makeuri 1.2.3.4 does it for me

@biopsin
Copy link
Contributor

biopsin commented Oct 25, 2021

I'll test it again tomorrow

@biopsin
Copy link
Contributor

biopsin commented Oct 26, 2021

Tested current hlip version with patch and the error is fixed, moving forward with hplip to latest release.
I also need to fix a makefile as "libImageProcessor-x86-XX.so" is not being picked moved up upon install
[issue source]

@biopsin
Copy link
Contributor

biopsin commented Oct 26, 2021

@ericonr a notice here , as they continue ship nonfree blobs, we should continue distribute a amputed version or move to nonfree?

Some log&issues

@biopsin biopsin mentioned this issue Oct 31, 2021
3 tasks
@alandiwix
Copy link
Author

alandiwix commented Nov 3, 2021

@ericonr would be nice if someone else could fix this.
I don't have too much experience with either void build system or python.

@ahesford
Copy link
Member

ahesford commented Dec 8, 2021

Should be closed in 6f33e38.

@ahesford ahesford closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants