Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: G4music #40961

Open
AgarimOSLinux opened this issue Dec 7, 2022 · 4 comments
Open

Package request: G4music #40961

AgarimOSLinux opened this issue Dec 7, 2022 · 4 comments
Labels
request Package request

Comments

@AgarimOSLinux
Copy link
Contributor

Package name

g4music

Package homepage

https://gitlab.gnome.org/neithern/g4music

Description

A fast, fluent, light weight music player written in GTK4, with a beautiful, adaptive user interface, so named G4Music. It is also focusing on high performance, for those people who has huge number of songs.

I've created a "pseudo-template" that needs to be polished (i don't understand the difference between hostmakedepends and makedepends, but i will paste my template here so maybe some could finish the work:

Hopefully it helps someone.
template.txt

Does the requested package meet the package requirements?

Required

Is the requested package released?

Yes

@AgarimOSLinux AgarimOSLinux added the request Package request label Dec 7, 2022
@paper42
Copy link
Member

paper42 commented Dec 7, 2022

Feel free to create a PR, we can discuss what should be adjusted in reviews there.

@AgarimOSLinux
Copy link
Contributor Author

@paper42 The reason that i did so, is because I don't how to work with git and open a pull request. Of course I can clone a repo, but if i have to backup my config I will have already problems.
I will see if I can learn it and do it as you said.

@AgarimOSLinux
Copy link
Contributor Author

I am working on it but i got this error:
g4music-1.8.2_1: running do_check ...
ninja: Entering directory `build'
[0/1] Running all tests.
1/3 Validate desktop file OK 0.02s
2/3 Validate schema file OK 0.01s
3/3 Validate appstream file FAIL 0.03s exit status 1

MALLOC_PERTURB_=219 /usr/bin/appstream-util validate --nonet data/com.github.neithern.g4music.appdata.xml
――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
stdout:
data/com.github.neithern.g4music.appdata.xml: FAILED:
• style-invalid :

    cannot start a description [(null)]
    • style-invalid : Not enough

    tags for a good description [0/1]
    stderr:
    Validation of files failed
    ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

Summary of Failures:

3/3 Validate appstream file FAIL 0.03s exit status 1

Ok: 2
Expected Fail: 0
Fail: 1
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Full log written to /builddir/g4music-1.8.2/build/meson-logs/testlog.txt
FAILED: meson-internal__test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
=> ERROR: g4music-1.8.2_1: do_check: '${make_check_pre} ${make_cmd} -C ${meson_builddir} ${makejobs} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR: in do_check() at common/build-style/meson.sh:141

@classabbyamp
Copy link
Member

those tests do not seem to be worth running, they don't test any of the application itself. i would set make_check=no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Package request
Projects
None yet
Development

No branches or pull requests

3 participants