Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] auto-disable debug and multilib for bootstrap packages? #42069

Closed
classabbyamp opened this issue Feb 4, 2023 · 6 comments
Closed

[RFC] auto-disable debug and multilib for bootstrap packages? #42069

classabbyamp opened this issue Feb 4, 2023 · 6 comments
Labels
question Further information is requested Stale xbps-src xbps-src related

Comments

@classabbyamp
Copy link
Member

@void-linux/pkg-committers

Should setting repository=bootstrap automatically disable debug and multilib package generation?

for reference: #39868

@classabbyamp classabbyamp added question Further information is requested xbps-src xbps-src related labels Feb 4, 2023
@ahesford
Copy link
Member

ahesford commented Feb 4, 2023

Yes.

@Duncaen
Copy link
Member

Duncaen commented Feb 4, 2023

Why?

@ahesford
Copy link
Member

ahesford commented Feb 4, 2023

We have no mechanism for actually tying debug/multilib packages to their parents and tend to leave behind stale debugs when we change the package tree even after manually removing the parents. If the bootstrap debug packages end up in the regular debug repo, it will lead to public clutter for packages that are obscured from general visibility anyway. If they end up in a bootstrap/debug repo, it's just another directory with a state that will deviate from the master. I can't imagine there's any real utility in the packages, so it's probably better to just skip them.

@Duncaen
Copy link
Member

Duncaen commented Feb 4, 2023

We have no mechanism for actually tying debug/multilib packages to their parents and tend to leave behind stale debugs when we change the package tree even after manually removing the parents.

We have source-revisions:

$ xbps-query --regex -Rp source-revisions -s "^zlib:"
zlib-1.2.13_1: zlib:5f1d95b23c (https://repo-fastly.voidlinux.org/current)
zlib-devel-1.2.13_1: zlib:5f1d95b23c (https://repo-fastly.voidlinux.org/current)
zlib-dbg-1.2.13_1: zlib:5f1d95b23c (https://repo-fastly.voidlinux.org/current/debug)
zlib-32bit-1.2.13_1: zlib:91837caec7 (https://repo-fastly.voidlinux.org/current/multilib)
zlib-devel-32bit-1.2.13_1: zlib:91837caec7 (https://repo-fastly.voidlinux.org/current/multilib)

We could also use that as a better way to delete packages in the future, instead of having file names we just have arch+source-revisions combos that we put in a script that looks up the packages and deletes them.

If they end up in a bootstrap/debug repo, it's just another directory with a state that will deviate from the master. I can't imagine there's any real utility in the packages, so it's probably better to just skip them.

They should end up there IMHO, adding magic to disable debug based on repository just because there might be no apparent utility doesn't seem like a good idea. Seems like a bug that is only using the templates repository for the the package itself and multilib, but not for debug.

@github-actions
Copy link

github-actions bot commented May 6, 2023

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 6, 2023
@Vaelatern Vaelatern removed the Stale label May 11, 2023
@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Stale xbps-src xbps-src related
Projects
None yet
Development

No branches or pull requests

4 participants