Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinkpad_acpi kernel module not picking up parameters from /etc/modprobe.d/* #43120

Open
ghost opened this issue Mar 30, 2023 · 0 comments
Open
Labels
bug Something isn't working needs-testing Testing a PR or reproducing an issue needed

Comments

@ghost
Copy link

ghost commented Mar 30, 2023

Is this a new report?

Yes

System Info

Void 6.1.21_1 x86_64 AuthenticAMD uptodate rrrmFFFFFFF

Package(s) Affected

linux6.1-6.1.21_1

Does a report exist for this bug with the project's home (upstream) and/or another distro?

i first noticed this issue with 6.1.20_1 and initially reported it here

Expected behaviour

should be able to send commands to /proc/acpi/ibm/fan. for example: echo 'level auto' > /proc/acpi/ibm/fan

Actual behaviour

cannot send commands to /proc/acpi/ibm/fan because thinkpad_acpi.fan_control=1 is not being set correctly at boot.

Immediately after a reboot:

# cat /etc/modprobe.d/thinkpad_acpi.conf
options thinkpad_acpi fan_control=1

# cat /sys/module/thinkpad_acpi/parameters/fan_control
N

# echo 'level auto' > /proc/acpi/ibm/fan
echo: write error: invalid argument  

Steps to reproduce

  1. add the kernel module thinkpad-acpi by running: modprobe thinkpad_acpi
  2. create a file in modprobe.d that contains the line options thinkpad_acpi fan_control=1
  3. reboot
  4. run cat /sys/module/thinkpad_acpi/parameters/fan_control. it will be incorrectly set to N

running rmmod thinkpad_acpi, then modprobe thinkpad_acpi to remove and add the module fixes the issue. when re-added the module gets the parameter from any file in /etc/modprobe.d/* like this:

# cat /etc/modprobe.d/thinkpad_acpi.conf
options thinkpad_acpi fan_control=1

# cat /sys/module/thinkpad_acpi/parameters/fan_control
N

# cat /proc/acpi/ibm/fan
status:         enabled
speed:          3900
level:          auto

# rmmod thinkpad_acpi
# modprobe thinkpad_acpi

# cat /sys/module/thinkpad_acpi/parameters/fan_control
Y

# cat /proc/acpi/ibm/fan
status:         enabled
speed:          3900
level:          auto
commands:       level <level> (<level> is 0-7, auto, disengaged, full-speed)
commands:       enable, disable
commands:       watchdog <timeout> (<timeout> is 0 (off), 1-120 (seconds))

adding thinkpad_acpi.fan_control=1 to the kernel command line also fixes the problem and it will be set correctly on boot.

@ghost ghost added bug Something isn't working needs-testing Testing a PR or reproducing an issue needed labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-testing Testing a PR or reproducing an issue needed
Projects
None yet
Development

No branches or pull requests

0 participants