Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv does not build with the vulkan option turned off #48914

Closed
Aicaya opened this issue Feb 24, 2024 · 1 comment
Closed

mpv does not build with the vulkan option turned off #48914

Aicaya opened this issue Feb 24, 2024 · 1 comment
Labels
bug Something isn't working needs-testing Testing a PR or reproducing an issue needed

Comments

@Aicaya
Copy link
Contributor

Aicaya commented Feb 24, 2024

Is this a new report?

Yes

System Info

Void 6.1.71_1 x86_64 AuthenticAMD uptodate rrmFFFFFFFFFFFFFF

Package(s) Affected

mpv-0.37.0_1

Does a report exist for this bug with the project's home (upstream) and/or another distro?

No response

Expected behaviour

Building mpv with vulkan disabled should work.

Actual behaviour

Build fails due to libplacebo-devel only being a dependency when the vulkan option is enabled.

I should note that the previous version of mpv built fine without it, so maybe the dependency is now mandatory? Don't really know what it does and the pull request merge seems to be recent, which is why I'm writing an issue instead of sending a fix.

Steps to reproduce

  1. ./xbps-src -o ~vulkan pkg mpv
  2. Wait.
@Aicaya Aicaya added bug Something isn't working needs-testing Testing a PR or reproducing an issue needed labels Feb 24, 2024
@chrysos349
Copy link
Contributor

here is the release notes for mpv-0.37 regarding libplacebo. see here - https://github.com/mpv-player/mpv/releases

This is the first release to unconditionally require libplacebo, but note that the new improved renderer (vo_gpu_next) is not yet the default.
...
meson: make libplacebo a required dependency

the template needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-testing Testing a PR or reproducing an issue needed
Projects
None yet
Development

No branches or pull requests

2 participants