Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] unvendor desktop files, icons, and similar files from the srcpkgs tree #49164

Open
13 of 82 tasks
classabbyamp opened this issue Mar 7, 2024 · 0 comments
Open
13 of 82 tasks

[RFC] unvendor desktop files, icons, and similar files from the srcpkgs tree #49164

classabbyamp opened this issue Mar 7, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed tracking for tracking larger sets of changes

Comments

@classabbyamp
Copy link
Member

classabbyamp commented Mar 7, 2024 •
edited
Loading

there are a number of packages that include void-created .desktop files, icons, and sometimes even other things like manual pages in srcpkgs/<pkg>/files/, when files like this should come from upstream or not at all. In a quick survey I did in the past, some of the vendored desktop files even have upstream-provided ones available! (in those cases, the desktop files we have are often outdated or different from upstream)

A rough count finds:

  • 91 .desktop files (a few should stay, like pipewire's)
  • 43 PNG, 2 xpm, and 2 SVG icons

IMO, most, if not all, of these should be removed and either replaced with an existing upstream one or contributed upstream. I'd be interested in working on that if it is desired.

It would also be nice to add some kind of lint for the future to prevent these from slipping in again, as I see it often in new package PRs.

@void-linux/pkg-committers thoughts?

  • Maelstrom
  • OpenJK - may need to upstream
  • PrusaSlicer
  • QSyncthingTray - abandoned upstream
  • Rocket.Chat-Desktop
  • Signal-Desktop
  • SweetHome3D
  • WindowMaker
  • XyGrib
  • Z80Explorer
  • android-studio
  • apache-directory-studio-bin
  • arduino
  • astromenace
  • blobby2
  • boinc
  • boswars - https://codeberg.org/boswars/boswars/pulls/43
  • caph
  • cavestory
  • chatty
  • clipgrab
  • darkplaces
  • dbeaver
  • doom3
  • dosbox
  • dot-xsession
  • dwm
  • eclipse
  • element-desktop
  • evilwm
  • fluxbox
  • freeplane
  • freerouting
  • fsv
  • gnurobbo
  • godot
  • gtkedit
  • imagescan
  • intellij-idea-community-edition
  • jmol
  • jwm
  • kickshaw
  • lbreakout2
  • marvin
  • maxima
  • mplayer
  • mupdf
  • netsurf
  • opensonic
  • pa-applet
  • pingus
  • pipenightdreams
  • polkit-gnome
  • pycharm-community
  • pymol
  • python-tkinter
  • python3-tkinter
  • qt5
  • quakespasm
  • quimup
  • rocksndiamonds
  • rox
  • runelite-launcher
  • rxvt-unicode
  • scid_vs_pc
  • sopwith
  • teamspeak3
  • tesseract
  • thunderbird
  • urbanterror
  • vapoursynth-editor
  • vkQuake
  • warsow
  • wireplumber
  • wm2
  • wmderland
  • wmx
  • xdemineur
  • xnec2c
  • xonotic
  • yquake2
  • zsnes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed tracking for tracking larger sets of changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@classabbyamp