xbps-install -Su does not inform about packages on hold

[svenper]

(moved from void-linux/void-packages#20130)

System

• xuname: Void 5.4.25_1 x86_64-musl GenuineIntel uptodate hold rrnFFFFFFFFFF
• package: xbps-0.59_5

Expected behavior

xbps-install -Su informs about packages on hold as it used to

Actual behavior

# xbps-install -Su
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ...
# xbps-install -S firefox
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ...

Name      Action    Version           New version            Download size
firefox   update    73.0.1_1          74.0_1                 57MB
...

Steps to reproduce the behavior

# xdowngrade /var/cache/xbps/firefox-73.0.1_1.x86_64-musl.xbps
# xbps-pkgdb -m hold firefox
# xbps-install -Su
# xbps-install -S firefox

[travankor]

It doesn't prompt any pkgs on hold.

I'm not sure if this is bad or good, though.

➤ doas xbps-install -Mu

Name               Action    Version           New version            Download size
alacritty          update    0.4.2_2           0.4.2_3                2091KB 
alacritty-terminfo update    0.4.2_2           0.4.2_3                3258B 
bemenu             update    0.4.1_1           0.4.1_2                56KB 
gdown              update    3.10.2_1          3.10.3_1               8971B 
keepassxc          update    2.5.3_1           2.5.4_1                8736KB 
python             update    2.7.17_3          2.7.18_1               5943KB 
python3-cairo      update    1.19.1_1          1.19.1_2               68KB 
python3-lxml       update    4.4.1_2           4.4.3_1                1653KB 

Size to download:               18MB
Size required on disk:          49MB
Space available on disk:       148GB

Do you want to continue? [Y/n] n
Aborting!
                                                                                                                                                                                                                    
travankor@enki:~
➤ doas xbps-pkgdb -m hold bemenu
                                                                                                                                                                                                                     
travankor@enki:~
➤ doas xbps-install -Mu

Name               Action    Version           New version            Download size                                                                                                                                                             
alacritty          update    0.4.2_2           0.4.2_3                2091KB                                                                                                                                                                    
alacritty-terminfo update    0.4.2_2           0.4.2_3                3258B                                                                                                                                                                     
gdown              update    3.10.2_1          3.10.3_1               8971B                                                                                                                                                                     
keepassxc          update    2.5.3_1           2.5.4_1                8736KB                                                                                                                                                                    
python             update    2.7.17_3          2.7.18_1               5943KB                                                                                                                                                                    
python3-cairo      update    1.19.1_1          1.19.1_2               68KB                                                                                                                                                                      
python3-lxml       update    4.4.1_2           4.4.3_1                1653KB                                                                                                                                                                    
                                                                                                                                                                                                                                                
Size to download:               18MB                                                                                                                                                                                                            
Size required on disk:          49MB                                                                                                                                                                                                            
Space available on disk:       148GB                                     

[svenper]

What I meant is that there is indeed no need to prompt, but it should still list the packages with updates available.

[travankor]

the patch doesn't fix this issue, but xbps-query -p hold bemenu from the previous example now says yes (pre-existing hold pkgs don't have this set)