Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapse 1.49.0 update deleted my productive server config #441

Closed
freshprince opened this issue Dec 22, 2021 · 8 comments
Closed

synapse 1.49.0 update deleted my productive server config #441

freshprince opened this issue Dec 22, 2021 · 8 comments

Comments

@freshprince
Copy link

post_install() {
	vsv synapse

	vinstall docs/sample_config.yaml 644 etc/synapse homeserver.yaml
	vinstall docs/sample_log_config.yaml 644 etc/synapse log.yaml
}

not really a good idea if someone already has a productive config in /etc/synapse/homeserver.yaml :(

@paper42
Copy link
Member

paper42 commented Dec 22, 2021

The file is mentioned in conf_files, so your config won't be overwritten.

@freshprince
Copy link
Author

cannot confirm my config file is gone

@paper42
Copy link
Member

paper42 commented Dec 22, 2021

Something like this should have happened if /etc/synapse/homeserver.yaml existed and you installed synapse:

synapse-1.49.0_1: unpacking ...
File `./etc/synapse/homeserver.yaml' exists, installing configuration file to `./etc/synapse/homeserver.yaml.new-1.49.0_1'.

@freshprince
Copy link
Author

# cat /etc/synapse/homeserver.yaml
feoofdsofjsod
# xbps-install -R. -u synapse

Name    Action    Version           New version            Download size
synapse update    1.48.0_1          1.49.0_1               -

Size required on disk:        6889KB
Space available on disk:      6535MB

Do you want to continue? [Y/n]

[*] Verifying package integrity
synapse-1.49.0_1: verifying SHA256 hash...

[*] Collecting package files
synapse-1.49.0_1: collecting files...
synapse-1.48.0_1: collecting files...

[*] Unpacking packages
synapse-1.48.0_1: updating to 1.49.0_1 ...
Removing byte-compiled python3.10 code for module synapse...
Removing byte-compiled python3.10 code for module synmark...
Updating ldconfig(8) cache...
synapse-1.49.0_1: unpacking ...
synapse-1.49.0_1: file `./etc/sv/synapse/run' won't be extracted, it's preserved.

[*] Configuring unpacked packages
synapse-1.49.0_1: configuring ...
Updated synapse system user.
Byte-compiling python3.10 code for module synapse...
Byte-compiling python3.10 code for module synmark...
Updating ldconfig(8) cache...
synapse-1.49.0_1: updated successfully.

0 downloaded, 0 installed, 1 updated, 1 configured, 0 removed.
# head /etc/synapse/homeserver.yaml
# This file is maintained as an up-to-date snapshot of the default
# homeserver.yaml configuration generated by Synapse.
#
# It is intended to act as a reference for the default configuration,
# helping admins keep track of new options and other changes, and compare
# their configs with the current default.  As such, many of the actual
# config values shown are placeholders.
#
# It is *not* intended to be copied and used as the basis for a real
# homeserver.yaml. Instead, if you are starting from scratch, please generate

@ArsenArsen
Copy link
Contributor

Can you post output with debug and verbose? I suspect the block below gets called.

/*
* First case: original hash not found, install new file.
*/
if (sha256_orig == NULL) {
xbps_dbg_printf(xhp, "%s: conf_file %s not installed\n",
pkgver, entry_pname);
rv = 1;
goto out;
}

@freshprince
Copy link
Author

sure
debug.txt

@Duncaen Duncaen transferred this issue from void-linux/void-packages Dec 22, 2021
@Chocimier
Copy link
Member

Duplicate of #342, fix at #426.
Should be fixed in void packages anyway, see void-linux/void-packages#34665

@freshprince
Copy link
Author

thanks. for completeness: void-linux/void-packages#34531 is the PR that introduced this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants