Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wish: configurable wait time #3

Closed
markstos opened this issue Aug 28, 2018 · 7 comments
Closed

wish: configurable wait time #3

markstos opened this issue Aug 28, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@markstos
Copy link

markstos commented Aug 28, 2018

If the error is 429: Over Quota, you may want to wait 15 minutes before trying again.

Supporting the "Exponential Backoff" algorithm is also useful if you are contacting a server which is trying to recover from high load, while at the same time it's being hammered by services which retrying their requests as fast they can waiting for it to come back up.

@void666 void666 added the enhancement New feature or request label Sep 6, 2018
@void666
Copy link
Owner

void666 commented Sep 6, 2018

@markstos makes sense to add exponential backoff. Adding it as an enhancement.

@void666 void666 closed this as completed Sep 6, 2018
@batmat
Copy link
Contributor

batmat commented Sep 13, 2018

@void666 did you close this on purpose? I believe you wanted to just add the label, but not close this request did you?

@void666 void666 reopened this Sep 14, 2018
@void666
Copy link
Owner

void666 commented Sep 14, 2018

My bad. Reopened it.

@batmat
Copy link
Contributor

batmat commented Sep 14, 2018

Feature proposed in PR #6

@mmcguff
Copy link

mmcguff commented Apr 30, 2019

Having number of retries and a wait interval for those retires that you can set by environmental variable would be very helpful. I am forking this repo and doing just that. I will PR my branch and you can decide if its worth including.

@batmat
Copy link
Contributor

batmat commented Apr 30, 2019

@mmcguff this feature is already ready and used in real conditions in #6

Interested to hear feedback from there. Let's build more together instead of another implementation from scratch I guess :). Thanks

@void666
Copy link
Owner

void666 commented Oct 31, 2019

Resolved in #6

@void666 void666 closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants