Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric prefixes #56

Closed
tropical32 opened this issue Dec 6, 2019 · 0 comments
Closed

Metric prefixes #56

tropical32 opened this issue Dec 6, 2019 · 0 comments

Comments

@tropical32
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'm always frustrated when I see mb (millibits) instead of MB (megabytes)

Describe the solution you'd like
I'd like to change mb to MB and gb to GB.

Describe alternatives you've considered
I have not considered any alternatives.

Additional context
Files to change:

  • __tests__/result.service.test.ts
  • src/constants/main.constants.ts
  • src/controller.ts
  • src/services/results.service.ts

Pull Request Link: #55
@zaldih zaldih closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaldih @tropical32