-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] win32
platform, UI flickering when removing node_module
directory/ies
#90
Comments
Hi @ognjenjevremovic !
I don't have any clue why is that, but doesn't seem that urgent in this case :) |
Thanks for the feedback @KonradNojman. I'd like to point out that I got access to a We might close soon enough if the issue gets stale (like a month without any activity) 🙂 . |
Hey! @KonradNojman have you been able to check if this problem also happens for example in CMD? |
cc @KonradNojman I didn't test this tbh on the VM; since I don't use |
Hey! Regards. |
Describe the bug
Deleting the
node_modules
directory on thewin32
platform causes flickering on the UI.Originally discovered by @KonradNojman in #87 (comment)
It might be related to the delete method in
win32
being synchronous since #88:as described by @zaldih.
For more info, please refer to #87 and #88 threads.
To Reproduce
Steps to reproduce the behavior (must be on
win32
platform!):node_modules
directory somewhere in the child chain,npx npkill
or alternatively installnpkill
globally (npm i -g npkill
) and spawnnpkill
,* (@KonradNojman please do fill in the gaps if I miss some of the steps)
Expected behavior
No flickers should occur when removing
node_modules
directory/ies.The status of
deleting...
andDELETED
should be updated accordingly (asynchronously).Screenshots
Here's the visual representation of this issue:
https://user-images.githubusercontent.com/60238331/110249637-4fb48b00-7f77-11eb-8cac-9d6259788f97.png
(courtesy of @KonradNojman)
Windows
v0.7.4
Additional context
cc @zaldih @NyaGarcia for visibility (and prioritization).
The text was updated successfully, but these errors were encountered: