Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voila-vuetify faills for voila 0.1.15 #18

Closed
JovanVeljanoski opened this issue Oct 29, 2019 · 6 comments
Closed

voila-vuetify faills for voila 0.1.15 #18

JovanVeljanoski opened this issue Oct 29, 2019 · 6 comments

Comments

@JovanVeljanoski
Copy link

Hi,

You are probably aware of this, but just to report that voila-vuetify fails for the latest version of voila 0.1.15

Example:

 voila --template vuetify-default simple_example.ipynb

Traceback (most recent call last):
  File "/Users/jovan/miniconda3/bin/voila", line 10, in <module>
    sys.exit(main())
  File "/Users/jovan/miniconda3/lib/python3.7/site-packages/traitlets/config/application.py", line 663, in launch_instance
    app.initialize(argv)
  File "/Users/jovan/miniconda3/lib/python3.7/site-packages/voila/app.py", line 348, in initialize
    self.setup_template_dirs()
  File "/Users/jovan/miniconda3/lib/python3.7/site-packages/voila/app.py", line 368, in setup_template_dirs
    assert conf['traitlet_configuration']['base_template'] == self.voila_configuration.template
KeyError: 'traitlet_configuration'

I hope this helps,

Cheers!

@SylvainCorlay
Copy link
Member

cc @mkcor should we keep that assert statement?

@mkcor
Copy link
Member

mkcor commented Oct 29, 2019

Well, I admit it's not fair to keep it if we don't document what the template config file should look like. That's a way to enforce a standard for Voilà template config files, but

  • the conversation to come up with it only happened there, maybe this should be a broader conversation;
  • once we agree on the standard, we should document it (at the moment, it's only mentioned in the voila-reveal announcement blog post).

@JovanVeljanoski don't you have a conf.json file under PREFIX/share/jupyter/voila/templates/vuetify-default/? Does it look like this:

{
  "traitlet_configuration": {
    "base_template": "vuetify-default",
    (...)
  }
}

Probably not, since the conversation hasn't happened broadly...
/cc @maartenbreddels

@JovanVeljanoski
Copy link
Author

JovanVeljanoski commented Oct 29, 2019

@mkcor

Yes, i do, but the file only contains this:

{"base_template": "vuetify-base"}

edit: my installation of voila and voila-vuetify is through conda-forge.

@mkcor
Copy link
Member

mkcor commented Oct 29, 2019

@JovanVeljanoski Makes sense. If you don't want to wait for #19 to be merged and voila-vuetify to be re-released on conda-forge, edit this conf.json file into

{
  "traitlet_configuration": {
    "base_template": "vuetify-default"
  }
}

for the moment.

Thanks for reporting, by the way!

@JovanVeljanoski
Copy link
Author

Thank you @mkcor and @SylvainCorlay for your swift reply. Feel free to close this when you see fit.

@SylvainCorlay
Copy link
Member

@JovanVeljanoski we have fixed the issue with voila 0.1.16

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants