Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog #369

Closed
jtpio opened this issue Aug 28, 2019 · 6 comments · Fixed by #912
Closed

Add a changelog #369

jtpio opened this issue Aug 28, 2019 · 6 comments · Fixed by #912

Comments

@jtpio
Copy link
Member

jtpio commented Aug 28, 2019

We should add a CHANGELOG.md to list (or generate) the changes after each release (we already got some questions about things that were fixed in subsequent releases)

@jtpio
Copy link
Member Author

jtpio commented Oct 2, 2019

@maartenbreddels you mentioned something about automatically generating the change log based on the commit messages (fix, feat, ...).

Is that still something to consider or are we fine taking a more "manual" approach? (and not enforce any commit style)

@maartenbreddels
Copy link
Member

semantic commits, or https://www.conventionalcommits.org/en/v1.0.0/
This last page seems like a good standard, it lists a tool for generating a changelog. It does require that we should squash/edit commit messages of contributors, since I don't think we can require external people to do so.

What do you think about it?

@jtpio
Copy link
Member Author

jtpio commented Oct 2, 2019

It does require that we should squash/edit commit messages of contributors

While I like the idea of generating the changelog automatically, squashing and editing commits would add extra work and is not very friendly wrt the git history.

@jtpio
Copy link
Member Author

jtpio commented Jun 23, 2021

github-activity generates nice changelogs based on GitHub labels (bug, enhancement, documentation...) with a list of contributors that have also been active in replying to issues: https://github.com/executablebooks/github-activity

This is also what the Jupyter Releaser uses, which will make things consistent if we adopt it for #805.

@jtpio jtpio mentioned this issue Jun 23, 2021
3 tasks
@slmg
Copy link

slmg commented Aug 14, 2021

Thank you for this addition, it definitely make it easier to browse changes!

Would it be possible to add a date as part of each change? It would make it easier to see what changed in say the last two-months.

Thanks!

@jtpio
Copy link
Member Author

jtpio commented Aug 26, 2021

Would it be possible to add a date as part of each change? It would make it easier to see what changed in say the last two-months.

The backfill was generated with github-activity (https://github.com/executablebooks/github-activity). We would probably need to do another pass on the changelog to add the dates manually, not sure this is supported by github-activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants