Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show error tracebacks to user without logging everything #616

Closed
vidartf opened this issue May 22, 2020 · 2 comments · Fixed by #630
Closed

Add option to show error tracebacks to user without logging everything #616

vidartf opened this issue May 22, 2020 · 2 comments · Fixed by #630

Comments

@vidartf
Copy link
Contributor

vidartf commented May 22, 2020

Currently, if you start voila in --debug mode almost everything gets logged. It would be nice to have a way to enable traceback for "developer" dashboards deployments without having the logs be as verbose as they are. Currently they are linked one-to-one here:

voila/voila/execute.py

Lines 36 to 38 in 80b120c

def should_strip_error(config):
"""Return True if errors should be stripped from the Notebook, False otherwise, depending on the current config."""
return 'Voila' not in config or 'log_level' not in config['Voila'] or config['Voila']['log_level'] != logging.DEBUG

A possibility would be to add a separate config option "send_tracebacks" that defaults to the current value (dependent on log level) if unset.

@SylvainCorlay
Copy link
Member

Maybe show_tracebacks instead of send_tracebacks.

@vidartf
Copy link
Contributor Author

vidartf commented Jun 5, 2020

Agreed. I would make a PR for this, but for the dev install on Windows a bunch of tests fail on master, so I assume Windows contributors are not supported 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants