You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thanks for all the good work, I think I already said it once but your library is and remains incredibly helpful!
#936 (commit d41d22f) seems to have broken code generation for classes with generic parents for me. I attached simplified samples of the issue below. The actual code is quite a bit more complicated, so in case you cannot reproduce it with these, please let me know so I can cook up something more complete.
which does not compile with ts 4.7.4 (yes I know it's a bit dated...), claiming that inheritance is not possible because not all fields of the PaymentSystemUnion are known, contrary to those of PaymentSystem
I have read the commit message and code, but it's been a while since I've done a deep dive into your code and am not quite sure what the intention of this change is, so I'm hesitant to propose a half-baked fix in a pull request and would not mind some pointers if you have any.
The text was updated successfully, but these errors were encountered:
First of all, thanks for all the good work, I think I already said it once but your library is and remains incredibly helpful!
#936 (commit d41d22f) seems to have broken code generation for classes with generic parents for me. I attached simplified samples of the issue below. The actual code is quite a bit more complicated, so in case you cannot reproduce it with these, please let me know so I can cook up something more complete.
Java:
Without #936:
With #936:
which does not compile with ts 4.7.4 (yes I know it's a bit dated...), claiming that inheritance is not possible because not all fields of the
PaymentSystemUnion
are known, contrary to those ofPaymentSystem
I have read the commit message and code, but it's been a while since I've done a deep dive into your code and am not quite sure what the intention of this change is, so I'm hesitant to propose a half-baked fix in a pull request and would not mind some pointers if you have any.
The text was updated successfully, but these errors were encountered: