Skip to content
This repository has been archived by the owner on Dec 12, 2019. It is now read-only.

Query String parameters should be URL encoded #12

Closed
wmbest2 opened this issue Dec 17, 2014 · 5 comments · Fixed by #18
Closed

Query String parameters should be URL encoded #12

wmbest2 opened this issue Dec 17, 2014 · 5 comments · Fixed by #18

Comments

@wmbest2
Copy link

wmbest2 commented Dec 17, 2014

No description provided.

@wmbest2
Copy link
Author

wmbest2 commented Dec 18, 2014

@vokal-isaac I know we discussed url encoding the full path but I think it may be worth keeping how we have it now with the dashes. Consider the following:

GET|%2Fv1%2Ftest%2Fparams%3Fsomething%3Dworked%26test%3Dtrue

vs

GET|-v1-test-params?something%3Dworked%26test%3Dtrue

@vokal-isaac
Copy link
Contributor

After discussion, it sounds like we've settled on leaving the path alone (save for replacing / and : with -) and having the keys and values in the query string be URL-encoded.

@wmbest2
Copy link
Author

wmbest2 commented Jan 2, 2015

What was the issue with : again?

@vokal-isaac
Copy link
Contributor

: was the path component separator used in Mac OS before OS X, so some applications (potentially including Finder) really don't like it when file names contain :.

@vokal-isaac
Copy link
Contributor

Resolved by #17.

@vokal-isaac vokal-isaac mentioned this issue Jan 3, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 2.0.0 vokal-isaac/VOKMockUrlProtocol
2 participants
@wmbest2 @vokal-isaac