New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Vietnamese to ASCII correct? #25

Closed

voku opened this issue Sep 15, 2019 · 2 comments

Labels

good first issue

Owner

voku commented Sep 15, 2019

Example: Is this correct?

"trường học" -> "truong hoc"

Can a native speaker, please check the character-replacement, thanks.

https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L723

voku added the good first issue label

cvhau commented Apr 14, 2021

I have checked, all special Vietnamese characters to ASCII mapping are correct.

Owner Author

voku commented Apr 15, 2021

Thanks for checking it. 🥇

voku closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment