Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using expire with remember #303

Open
ibraheemdev opened this issue Aug 10, 2020 · 1 comment
Open

Using expire with remember #303

ibraheemdev opened this issue Aug 10, 2020 · 1 comment

Comments

@ibraheemdev
Copy link
Contributor

ibraheemdev commented Aug 10, 2020

Above the expire middleware, there is a comment stating:

// This middleware conflicts with use of the Remember module, don't enable both
// at the same time.

If you use both modules together, which one will take precedence? Will the user be logged out after the timeout period? Or will the user be logged out after the remember cookie expires?

This was also an issue with devise, and they chose to change it so that if a user clicks remember me, he will not be timedout.

@ibraheemdev ibraheemdev changed the title Can you really not use the expire middleware along with the remember module? Using expire with remember Aug 10, 2020
@aarondl
Copy link
Member

aarondl commented Aug 10, 2020

They will conflict in that the remember me will continuously log the user back in after they're expired. This will create a jarring user experience :)

I welcome a change in the behavior. It would not be considered breaking because nobody should currently be using them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants