Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to stop EventLoop from inside an event #337

Open
larrycinnabar opened this issue Apr 19, 2022 · 1 comment · May be fixed by #338
Open

Add ability to stop EventLoop from inside an event #337

larrycinnabar opened this issue Apr 19, 2022 · 1 comment · May be fixed by #338

Comments

@larrycinnabar
Copy link

What about an option to stop (Halt) event loop from inside an event?
return true, nil will still loop through all registered hooks in the given event chain, and there is no option to stop and do not continue to following registered hooks
@larrycinnabar larrycinnabar linked a pull request Apr 19, 2022 that will close this issue
Open
@aarondl
Copy link
Member

aarondl commented Nov 8, 2023 •
edited
Loading

What is the purpose behind this? The event handler signature passes in the handled bool so the decision rests in the event handlers themselves. A hard halt can prevent important event handlers from running - even those that MUST run every time (like a lock module that must know every time auth has failed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Events ability to halt AaHaInc/authboss
2 participants
@aarondl @larrycinnabar