Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The mainline CI fails, and an error is reported when parsing grafana.yaml #2727

Closed
wangyang0616 opened this issue Mar 9, 2023 · 4 comments · Fixed by #2728
Closed

The mainline CI fails, and an error is reported when parsing grafana.yaml #2727

wangyang0616 opened this issue Mar 9, 2023 · 4 comments · Fixed by #2728
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@wangyang0616
Copy link
Member

What happened:
After #2718 was merged into the trunk, the trunk CI reported an error, which resulted in the inability to merge subsequent PRs.

The main CI project fails, and the error message is as follows:
image

What you expected to happen:
The master CI is running normally

How to reproduce it (as minimally and precisely as possible):
make update-development-yaml

Anything else we need to know?:

Environment:

  • Volcano Version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@wangyang0616 wangyang0616 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2023
@wangyang0616
Copy link
Member Author

In #2718, the transfer characters of some keywords in legendFormat are cleaned up, such as: le, queue, job_namespace, and volcano-namespace.

According to the description of #2717 to fix the problem, this time the definition in grafana.yaml will be restored to 1773 state

@wangyang0616
Copy link
Member Author

wangyang0616 commented Mar 9, 2023

@shaobo76 Hello my friend, you can pay attention to whether the current pr modification can meet your needs. If there are any problems, we can discuss them in the current issue and look forward to your reply.

@shaobo76
Copy link
Contributor

shaobo76 commented Mar 9, 2023

Sorry for the trouble. I removed the '\' around '{{' to make it looks good as a grafana dashboard. But I didn't realize that it'll break the helm template command. The correct way to escape double curly brackets in Go templates is like {{ "{{queue}}" }} or {{ ` {{queue}} ` }}.

@wangyang0616
Copy link
Member Author

wangyang0616 commented Mar 10, 2023

Sorry for the trouble. I removed the '' around '{{' to make it looks good as a grafana dashboard. But I didn't realize that it'll break the helm template command. The correct way to escape double curly brackets in Go templates is like {{ "{{queue}}" }} or {{ {{queue}} }}.

It’s okay, we are very happy that you can contribute. I will first restore grafana.yaml to the state with \ to ensure the normal operation of CI. If necessary, you can optimize it according to your needs and run make update-development-yaml Guarantee that the result is passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants