Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly a typo in the code. #106

Closed
aleksey-r opened this issue Aug 5, 2020 · 2 comments
Closed

Possibly a typo in the code. #106

aleksey-r opened this issue Aug 5, 2020 · 2 comments
Assignees
Labels

Comments

@aleksey-r
Copy link

The parameter "culture" for the Russian language is ru_ru instead of ru-ru.
https://github.com/volks73/cargo-wix/blob/master/src/lib.rs

Cultures::RuRu => write!(f, "ru_RU"),
...
"ru_ru" => Ok(Cultures::RuRu),
...

Result of "cargo wix -c ru-ru" execution:

Error[2] (Generic): Unknown 'ru-ru' culture

Result of "cargo wix -c ru_ru" execution:

Error[1] (Command): The 'light' application failed with exit code = 102. Consider using the '--nocapture' flag to obtain more information.
@volks73 volks73 added the bug label Aug 5, 2020
@volks73 volks73 self-assigned this Aug 5, 2020
@volks73
Copy link
Owner

volks73 commented Aug 5, 2020

Thank you for the bug report. Yes, this is a typo for the Russian culture. It should be a dash/hyphen not an underscore. It is an underscore in two separate places in lib.rs. I am in the process of fixing and look to a get a bugfix release shortly.

@volks73
Copy link
Owner

volks73 commented Aug 5, 2020

Fixed as of 508e3e1.

Creating a new release shortly.

@volks73 volks73 closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants