Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage Indicators - Incompatability with changing weapon damage #17

Closed
TheWranger opened this issue Feb 17, 2019 · 3 comments
Closed

Damage Indicators - Incompatability with changing weapon damage #17

TheWranger opened this issue Feb 17, 2019 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TheWranger
Copy link

My server uses the plugin OldCombatMechanics - which modifies the damage of weapons and tools to match that of what it used to be pre-1.9. Damage Indicators don't display the new damage values used by the weapons/tools and instead display the default 1.9 damage values.
image
Pic related: The boss bar (from a different plugin) displays what the actual damage value is but Gloss's Damage Indicators display the incorrect vanilla value.

@TheWranger TheWranger changed the title Damage Indicators - Problem with changing weapon damage Damage Indicators - Incompatability with changing weapon damage Feb 17, 2019
@TheWranger
Copy link
Author

It also displays the wrong amount of damage when fighting against something with armor.

@cyberpwnn cyberpwnn self-assigned this Feb 22, 2019
@cyberpwnn cyberpwnn added the bug Something isn't working label Feb 22, 2019
@cyberpwnn
Copy link
Owner

The damage indicators display the actual damage dealt to the target.

  1. Your plugin is probably cancelling the event and firing a "damage event" without an entity cause. If this is the case, gloss wont be able to tell who did the damage and therefore cant track it.
  2. Armor calculation happens after gloss displays the damage, this can be fixed easily. Thanks!

@cyberpwnn cyberpwnn added this to the Gloss Release milestone Feb 22, 2019
@TheWranger
Copy link
Author

Works properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants