Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using async! dependency with = in the URL when converting a module #169

Open
foxbunny opened this issue Sep 9, 2013 · 1 comment
Open
Milestone

Comments

@foxbunny
Copy link

foxbunny commented Sep 9, 2013

When adding a file that requires google maps, I've tried to specify a dependency using the async plugin.

List any dependencies, comma separated, no spaces:  async!https://maps.googleapis.com/maps/api/js?key=KEY&sensor=false
What global to use for exported value []:  google.maps

This results in a wrapper that looks like this:

//Wrapped in an outer function to preserve global this
(function (root) { var amdExports; define(['async!https://maps.googleapis.com/maps/api/js?key'], function (KEY&sensor=false) { (function () {

Couldn't find a way to work around this. I've tried escaping the equals characters with a backslash, but that just causes the backslash to be included in the dependency path with virtually identical result. Quoting did not help either.

The original intention was to have an empty .js file to use for shimming, but I thought it'd be nice to be able to create a wrapper using volo. I currently work around this by reverting to shim configuration and adding a dummy AMD module that has no dependencies and exports null.

@jrburke
Copy link
Member

jrburke commented Sep 20, 2013

Looks like the parsing for = separators for command line name=value pairs is getting in the way for this. Putting it in the 0.3.1 bucket.

@jrburke jrburke modified the milestones: 0.4.0, 0.3.2 May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants