Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh is dependent on cwd #49

Closed
ianb opened this issue May 29, 2012 · 4 comments
Closed

build.sh is dependent on cwd #49

ianb opened this issue May 29, 2012 · 4 comments

Comments

@ianb
Copy link

ianb commented May 29, 2012

If you call build.sh from another directory, r.js can't be found.

One solution for bash is to use $BASH_SOURCE, like HERE="$(dirname $BASH_SOURCE)"

At least testing that r.js exists would allow for a better error message.

@jrburke
Copy link
Member

jrburke commented May 29, 2012

Related to #48, needs more context on where build.sh comes from, I do not see it in the volo tree, perhaps a specific use of volo in another project is in play?

@ianb
Copy link
Author

ianb commented May 29, 2012

I simply did volo create test-project and that created test-project/tools/build.sh – I'm not sure where it came from.

@jrburke
Copy link
Member

jrburke commented May 29, 2012

Ah ok, looking at the output from that command, it came from https://github.com/volojs/create-template/zipball/master. I'll move the bugs over there. I'm updating that one now anyway.

@jrburke
Copy link
Member

jrburke commented May 29, 2012

This is resolved in the template now by using a volofile to run the build. That way it will work on windows too. volo build from within the created project will do it for any new projects created from that volojs/create-template template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants