Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release_v1.0.zip style heuristic to tag checking #50

Open
dmose opened this issue May 30, 2012 · 3 comments
Open

add release_v1.0.zip style heuristic to tag checking #50

dmose opened this issue May 30, 2012 · 3 comments

Comments

@dmose
Copy link

dmose commented May 30, 2012

Right now, "volo add EaselJS" pulls the master branch, even though tags are available, because the tags have a somewhat unusual format; https://github.com/CreateJS/EaselJS/tags has examples. It strikes me as reasonable to include "prepended with release_v" into the heuristic that's currently used.

@jrburke
Copy link
Member

jrburke commented May 30, 2012

This goes against the usual git/hub convention of 'vX.X.X' or just 'X.X.X'. Someone else may have a 'rel_v' or some other weird prefix, and I'm reticent to add more since it also increases the likelihood of false positives for version tags when they are just branches (git flow release branches come to mind?). I would instead encourage the developer to use more standardized tag names.

In the meantime, a fixed version volojs/repos package.json override could be used.

@dmose
Copy link
Author

dmose commented Jun 5, 2012

Agreed, there are indeed other ways around this issue. My thinking in suggesting this was more that it struck me as wildly unlikely that "release_vX.X.X" would be intended to mean something semantically different than "vX.X.X", so that the chances of false positives would be vanishingly small.

@blackjk3
Copy link

What about Three.js using r49, etc for their tagging strategy? The list could go on forever. I have been writing something similar to pull down a repo version based on github tags and it is has been very difficult based on all these different tagging strategies. Wouldn't it be nice if the community would be more consistent :- )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants