Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visible indication while fetching the public node listing #33

Closed
dherman opened this issue Feb 10, 2018 · 1 comment · Fixed by #57
Closed

visible indication while fetching the public node listing #33

dherman opened this issue Feb 10, 2018 · 1 comment · Fixed by #57

Comments

@dherman
Copy link
Collaborator

dherman commented Feb 10, 2018

I believe fetching the public node listing is causing a pause with no visible indication to the user. Test this hypothesis, and if it's true, we should:

  • show an activity and/or progress indicator while fetching it
  • possibly cache it

I'm not sure if the caching semantics works, since it could mean missing new versions. So we should think that through.

@mikrostew
Copy link
Contributor

mikrostew commented Mar 30, 2018

When running notion install <version> I am seeing a pause during this period, especially on my slow home internet.

A quick check shows this is taking almost 3/4 of a second for me:

$ time curl https://nodejs.org/dist/index.json
(...lots of JSON...)

real	0m0.705s

I don't think that caching makes sense for this, unless there is syntax to install multiple node versions at the same time, something like notion install 8.9 9.4.7 lts. In that case we should only fetch the public registry once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants