Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exec in unix #37

Open
dherman opened this issue Feb 10, 2018 · 2 comments
Open

use exec in unix #37

dherman opened this issue Feb 10, 2018 · 2 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Feb 10, 2018

For unixes at least, I suspect it would be easier to implement a correct delegation for Tool::exec by using a Unix exec call. But this is an area I need to dig into more. (Expert advice welcome!)

@frangio
Copy link

frangio commented Jan 3, 2022

Are there specific challenges to using exec?

The process view is quite poluted because every shim spawns a child process rather than replacing itself with the tool, e.g.:

node
└─ node

@charlespierce
Copy link
Contributor

@frangio At this point, I believe the main challenge to using exec is that we support configuring telemetry that runs once the underlying task is finished, which wouldn't happen any more if we spawned the actual process using exec. That said, with some design work, we may be able to work around that issue (spawning a separate process iff the telemetry is configured to send that info) and use exec.

Another possible complication would be that I believe Windows has different semantics for exec, which may require the implementation to include some extra platform-specific logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Features
Development

No branches or pull requests

3 participants