Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session.node() should return a clearer enum #43

Closed
dherman opened this issue Feb 16, 2018 · 2 comments
Closed

session.node() should return a clearer enum #43

dherman opened this issue Feb 16, 2018 · 2 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Feb 16, 2018

To avoid the complicated conditionals, the session.node() method should return an enum of which "kind" of Node we got (global vs project). That enum should have a method that produces an Option<Version>.

This maybe wants to be reconciled with the Installed type returned by install_node.

@mikrostew
Copy link
Contributor

mikrostew commented Mar 30, 2018

FYI session.node() was renamed to session.current_node() (see a4c4a31#diff-bee44139ca738f1c26ba310a684d6ddfR62)

@charlespierce
Copy link
Contributor

While we don't have a session.current_node method any more, we did recently add the ability to show where the session.current_platform() came from in #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants