Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include scope for string-valued bin #963

Closed
charlespierce opened this issue Mar 15, 2021 · 0 comments · Fixed by #969
Closed

Don't include scope for string-valued bin #963

charlespierce opened this issue Mar 15, 2021 · 0 comments · Fixed by #969
Labels

Comments

@charlespierce
Copy link
Contributor

We support both a hash and a string for the bin entry in package.json. When using a string, it's interpreted as the path to the binary, while the name for the binary is the name of the package. However, to match the behavior of the package managers, when the package is scoped, we should not include the scope in the binary name, only the unscoped package name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant