Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ursabot option to force re-run benchmarks #111

Open
ianmcook opened this issue May 19, 2023 · 2 comments
Open

Add an ursabot option to force re-run benchmarks #111

ianmcook opened this issue May 19, 2023 · 2 comments
Assignees

Comments

@ianmcook
Copy link

Currently if you do @ursabot please benchmark and the last commit has already been benchmarked then ursabot replies with Commit xxxxxxx already has scheduled benchmark runs. This is a good default, but it would be nice to have an option to force re-run the benchmarks on the same commit, for example if you suspect that a regression might just be noise.

@ianmcook ianmcook self-assigned this May 19, 2023
@austin3dickey
Copy link
Collaborator

I think this will require us to stop using the commit hash as the primary key of the Benchmarkable table. If we put the commit string that we currently use into a different column, then we could have multiple Benchmarkable entries with different primary keys that refer to the same commit. This will require careful testing to ensure we don't break things.

@alistaire47
Copy link
Contributor

I messed with this a while ago, and there are some strong and not great assumptions about run_id that messing with this will likely violate, so this may turn into a bit of a mess that has to touch quite a lot of the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants